communi / libcommuni

A cross-platform IRC framework for Qt
https://communi.github.io
BSD 3-Clause "New" or "Revised" License
83 stars 37 forks source link

passwords not transmitted correctly #67

Closed velartrill closed 4 years ago

velartrill commented 4 years ago

the current way communi communicates server passwords to the server results in login failures if passwords contain a space character. currently, the only way to connect to a server if a server password contains a space is to leave the "password" field blank, and then run e.g. /quote PASS :123 to connect with the password 123.

this is likely due to a quirk in the IRC protocol - the similar /quote PASS 123 command often also works but not when the password contains a space - /quote PASS :123 456 correctly transmits a password of 123 456 but /quote PASS 123 456 sends a password of 123 and an invalid extra argument. however, a space character will also prevent passwords from being accepted when connecting in SASL mode, and i have no idea what's causing this.

(experienced the problem in communi-desktop; apologies if this isn't a library issue)