Revise: reduce warnings by handling some code that Qt has declared obsolete

communi / libcommuni

A cross-platform IRC framework for Qt

https://communi.github.io

BSD 3-Clause "New" or "Revised" License

84 stars 37 forks source link

Revise: reduce warnings by handling some code that Qt has declared obsolete #86

Closed SlySven closed 3 years ago

SlySven commented 3 years ago

As of Qt 5.15.0 I am finding that some items are producing obsolete or deprecated code warnings. Specifically:

the QString::SplitBehaviour enum has been replaced by a Qt::SplitBehaviour one (in Qt 5.14)
qrand() and qsrand() have been declared obsolete and the former can be replaced with methods in a QRandomGenerator class. Originally provided in Qt 5.10 and declared obsolete in some version after that.

Signed-off-by: Stephen Lyons slysven@virginmedia.com

jpnurmi commented 3 years ago

Thanks!

(And thanks Qt for the evergoing deprecation dance... it wouldn't have hurt to keep backward compatible aliases without deprecating them :man_facepalming:)

SlySven commented 3 years ago

Especially within the same blooming release! The rejection of the QList<T>::toSet() / QSet<T>::toList() methods and the simplest replacement being by a multiple-line std "range" initialisation of an intermediate local broke things in the project I code for (which uses your library) when I did not catch on to the fact that the begin() and end() iterators for the range to initialise that local had to come from the same object!

BTW Is the 3.6.0 release due anytime soon?

jpnurmi commented 3 years ago

BTW Is the 3.6.0 release due anytime soon?

Yes, it's about time!