search

communiteq / discourse-adsense

Google AdSense plugin for Discourse forum
GNU General Public License v2.0
32 stars 32 forks source link

Adsense plugin breaks spinner animation #13

Open geckolinux opened 9 years ago

geckolinux commented 9 years ago

Hello, this plugin breaks the spinner animation on Discourse.

https://meta.discourse.org/t/suggested-topics-displayed-as-en-undefined/23415/7?u=sb56637

I'm on Discourse 1.2.0.beta4, and I believe this breakage is new to beta4.

thangngoc89 commented 9 years ago

Nope. It was there since a commit on beta 3.

bartv42 commented 9 years ago

Any updates? This one's bothering me as well.

thangngoc89 commented 9 years ago

@bartv42 I created a pull request here to fix it in 1.2.0beta4. You can use it if you want https://github.com/discoursehosting/discourse-adsense/pull/14

bartv42 commented 9 years ago

Thanks, but I'm not too technical. I'll wait for it to appear in a future update, but it's good to hear it's been fixed!

thangngoc89 commented 9 years ago

@bartv42 I created this pull request 24 days ago. but no reply or anything. If you want to fix it right now. You can change from Discoursehosting repo to my : https://github.com/thangngoc89/discourse-adsense (in app.yml)