search

communitiesuk / epb-register-api

MIT License
8 stars 5 forks source link

Typo in BaseDataTypes.xsd and Reported-Data.xsd #14

Open rogerdawkins opened 4 years ago

rogerdawkins commented 4 years ago

Line 223 and 224 of BaseDataTypes.xsd has ACRatedOuput and should be ACRatedOutput (missing 't') in Type name

The type is then referred to in Reported-Data.xsd on lines 520 & 689 so needs fixing there too.

The above line numbers refer to the CEPC-8.0.0 files.

TheDoubleK commented 4 years ago

Thanks for this @rogerdawkins - good spot.

There is a problem with just fixing this right now: this error has been carried over from the legacy schema that we've inherited, and there is already a bunch of software out there that produces output to match the schema with the misspelled element (and probably has done for 10 years or more). We'll have to get in touch with Air Conditioning report software providers to co-ordinate the change in element name.

But thanks for raising the issue - we will definitely get things moving to put it right... it just won't be immediate.

rogerdawkins commented 4 years ago

@TheDoubleK No probs. The typo doesn't appear in the XML output, it is only an element and complexType definition in the XSD files so may be easier to implement. I'll leave it with you.