Open Jordan-Hall opened 2 years ago
Alpha Gov component was made using React Class base component and used outdated lifecyle hooks that will be removed from React, as a result it was all changed to React Functional component using hooks.
ariaActivedescendant = false not valid aria: When testing the component and after writing this in functional I noticed this error https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L619-L621
The alpha gov has an issue when the value changes but the length the same - https://github.com/alphagov/accessible-autocomplete/pull/496 This was fixed during a huge change the the way the component works and the object you can use https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L82-L93 This change believe also added a new concept that is not part of the Alpha Gov, this can be used as a select box https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L87 This means the object can be just a string, an object with label, name or value. This also means when you select a value, we display the actual label value https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L90-L93
https://github.com/alphagov/accessible-autocomplete/pull/467was migrated and merged into this version too
cc: @adrianclay Not sure if you have seen this.
Alpha Gov component was made using React Class base component and used outdated lifecyle hooks that will be removed from React, as a result it was all changed to React Functional component using hooks.
ariaActivedescendant = false not valid aria: When testing the component and after writing this in functional I noticed this error https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L619-L621
The alpha gov has an issue when the value changes but the length the same - https://github.com/alphagov/accessible-autocomplete/pull/496 This was fixed during a huge change the the way the component works and the object you can use https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L82-L93 This change believe also added a new concept that is not part of the Alpha Gov, this can be used as a select box
https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L87 This means the object can be just a string, an object with label, name or value. This also means when you select a value, we display the actual label value https://github.com/communitiesuk/gov-uk-dash-react-components/blob/46861544638cb678597df41a810449a1686e04db/src/lib/fragments/AutoComplete.react.js#L90-L93
https://github.com/alphagov/accessible-autocomplete/pull/467was migrated and merged into this version too