search

community-of-python / microbootstrap

Bootstrap your microservices in a second!
28 stars 2 forks source link

Fix offline Swagger UI for Litestar #27

Closed vrslev closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 98.19% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
microbootstrap/bootstrappers/litestar.py 97.01% <100.00%> (-0.17%) :arrow_down:
insani7y commented 1 month ago

I would not enforce users to use our hardcoded version of openapi static, cause in our litestar offline docs package (as well as in fastapi's package) static files are built in to the package.

vrslev commented 1 month ago

Meaning, you’d prefer it to be disabled by default? Or I didn’t understand what you mean exactly

vrslev commented 1 month ago

static files are built in to the package

The package with static files is shipped either way

vrslev commented 1 month ago

I've disabled offline docs by default. Also Swagger UI is not enforced if offline docs are disabled.

The fix still applies: otherwise offline docs do not work.