communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

Docusign - Date is not displayed as per client timezone #1060

Open nirupamav opened 4 years ago

nirupamav commented 4 years ago

Background

  1. Login to corporate console as nirupamavclamanager101
  2. Click on the Company RequestAccessTest
  3. Click SIGN NEW CLA
  4. Search and Select project ProjMay062020
  5. Click SUBMIT
  6. Click YES
  7. Click OPEN CLA
  8. Observed data is not displayed as per client timezone. I signed the CLA in IST timezone on 6th May but in docusign it displayed 5th May image
dealako commented 3 years ago

@rinkeshbhutwala can you determine if this value is set in the signing request in Python or somewhere else???

Please review the logic that creates the Docusign signing request: https://github.com/communitybridge/easycla/blob/master/cla-backend/cla/models/docusign_models.py#L868

Ask Harold if you need Python help - but I think hopefully you can understand the logic and maybe identify where the date/time is set???

Let us know if this is not possible to adjust based on user's timezone.

rinkeshbhutwala commented 3 years ago

@dealako I have verified this ticket regarding the date issue while we getting a date that time we need to convert date with the local timezone I also discuss this with @wanyaland as well.

nirupamav commented 3 years ago

Issue is still reproducible. I am trying to sign on 02-11-2020 but in Docusign it shows 01-11-2020 image.png

dealako commented 3 years ago

@makkalot can we allow DocuSign to set this value based on the client's date/time zone. Have you seen anything like this in the DocuSign API. Obviously, this value should be set when the user completes the signing process. Can this be calculated and set by DocuSign?

makkalot commented 3 years ago

I checked this and seems there are some rules that Docusign follows for this : https://support.docusign.com/en/articles/Why-is-the-date-signed-field-displayed-as-Pacific-Time-Zone-PDT

So, depends what we want to do about it, we can try set it from our API by getting the user's timezone. This way the user will see the timezone we've set. Need to experiment with dateSignedTabs field if it's editable by us, might not be. The other thing we can do is login on Admin/Sender in docusign side of things and see if there's option to display user's timezone instead of the default PST one.

@dealako

vinod-kadam commented 3 years ago

@dealako to review this one & decide what to do with it - it is an edge case.

dealako commented 3 years ago

I'm working to re-gain access to DocuSign to determine if I can adjust the settings.