search

communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

Newly added Signing Entity Name not appearing on Docusign for the user #2455

Closed manishv09 closed 3 years ago

manishv09 commented 3 years ago

Newly added Signing Entity Name not appearing on Docusign for the user (DEV Environment) Steps to Reproduce: Precondition:

  1. User has existing organization on SDFC (Swiggy.com)
  2. User navigates from corporator console and add new signing Entity name
  3. click on porceed to corporate console to sign CCLA
  4. User hit start signing process on corporate console to navigate to docusign

Expected Newly added signing entity name should be displayed to the user on docusign

Actual: Newly added signing entity name not be displayed to the user on docusign and sdfc also not updated with newly added signing entity name image.png

manishv09 commented 3 years ago

@makkalot As discussed over evening standup, please find the required details as follows: 0017c00000lMGfoAAG Company name "Tata Chemicals Ltd." Newly created user for above mentioned company "manishv.tatachem@proximabiz.com" image.png image.png image.png

makkalot commented 3 years ago

I can see that 2 company entries are created on EasyCLA side for each of the signing entity name :

Screenshot 2021-01-15 at 17.16.10.png

Screenshot 2021-01-15 at 17.16.23.png

when we click next how do we decide which company is going to be selected @dealako @amolsontakke3576 ? Also about adding non-existing signing entity names, should we also update the org service about it ? What's the expected behaviour ?

makkalot commented 3 years ago

Just to add the findings here related to the issue, the user gets associated randomly with company during requestCorporateSignature (because we query via externalCompanyID) : https://github.com/communitybridge/easycla/blob/main/cla-backend-go/v2/sign/service.go#L132

Screenshot 2021-01-19 at 18.16.05.png

Screenshot 2021-01-18 at 17.48.16.png

Screenshot 2021-01-18 at 17.48.42.png

Screenshot 2021-01-19 at 18.00.36.png

in the screenshots above as it's seen the user was expecting to see Mozilla India Inc new in docusign but as it's seen he was associated with Mozilla India Inc because of that mentioned random behaviour.

As a result we need a way to associate the user with company with correct signing entity before the signing happens.

vinod-kadam commented 3 years ago

As discussed by @dealako with @pranab-bajpai & Sudhakar, support is needed from Corporate Console for this one. LFX ticket created for change in Corporate Console is as follows: https://jira.linuxfoundation.org/browse/LFX-3047: Add support for Signing Entity in CCLA in Corporate Console

dealako commented 3 years ago

API updates deployed to DEV, STAGING and PROD. Awaiting final updates to v2 Corporate Console before QA can review final product.

manishv09 commented 3 years ago

Verified today on staging environment and found user is able to register new user and for that new user the signing entity name is appearing correct on docusign. Please attached video for more details.

https://images.zenhubusercontent.com/194341141/d9bd02a4-cc4a-4849-89df-2b435ea8e270/bug2455_25012021.mp4