v2 - Member portal - wrong time reported in event log when verifying with ccla

communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.

https://easycla.lfx.linuxfoundation.org

MIT License

64 stars 45 forks source link

v2 - Member portal - wrong time reported in event log when verifying with ccla #2655

Open WillsonHG opened 3 years ago

WillsonHG commented 3 years ago

When a user is verifying under a company's ccla, the event log is recording the time the row for the signature was created in the signatures table instead of the time the user actually verified.

User hwccla verified at 11:01pm

Event log shows 10:54pm

Database shows that 10:54 was the time the row for the signature was created, not when the actual verification occurred.

makkalot commented 3 years ago

The event that's pointed out is : https://github.com/communitybridge/easycla/blob/9454cc1697c7e1bad842bad840b9bde8f1790bfa/cla-backend/cla/models/docusign_models.py#L805 only records the signature creation not the signing. There should be another event there which is in form of A corporate signature was signed for project which should have the correct date. Maybe we should change the wording for the event that's saved on Signature creation ? @dealako

nickmango commented 4 months ago

@WillsonHG actually the time the user acknowledged(verified) being a part of the company is the same time the ecla record is actually created and the event is captured for that EventType.EmployeeSignatureCreated which should be the expected behavior.

thakurveerendras commented 4 months ago

Hello @nickmango The user-acknowledged activity log does not appear. Kindly review

nickmango commented 4 months ago

@thakurveerendras did you acknowledge via contributor console ? when affiliating to a company ?

nickmango commented 4 months ago

auto-ecla needs to be set to false for this to work

mlehotskylf commented 4 months ago

@thakurveerendras to retest this.

thakurveerendras commented 4 months ago

@nickmango , Tested with SUN, Earth & Venus project and found that the user-acknowledged activity log is missing.

thakurveerendras commented 3 months ago

On the existing setup it is not working & Testing on the new setup is blocked by a PCC issue https://github.com/linuxfoundation/lfx-pcc/issues/2446

thakurveerendras commented 2 months ago

@amolsontakke3576 Kindly review the PCC issue https://github.com/linuxfoundation/lfx-pcc/issues/2446 it blocked testing on easycla

thakurveerendras commented 1 month ago

Hi @nickmango Tested with new setup & found that The user-acknowledged activity log does not appear.

Kindly review the video clip: 2655.webm

nickmango commented 1 month ago

@thakurveerendras kindly verify this

thakurveerendras commented 4 weeks ago

Checked activity log time for the event "acknowledged the CLA employee affiliation for company" and found that it is correct after fix on the dev site. So updating this issue status

Refer screenshot for more details