communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
62 stars 45 forks source link

EasyCLA Bug Report: Confusing project information in new administrator notice #3498

Open jberkus opened 2 years ago

jberkus commented 2 years ago

Summary

When new administrators are notified via email of their status, the project named in the notification email is incorrect.

Background

  1. Added a new administrator for Red Hat, project CNCF.
  2. The new admin received an email that said this:

"You have been added as a CLA Manager for the organization Red Hat, Inc. and the project OpenTelemetry. This means that you can now maintain the list of employees allowed to contribute to the project OpenTelemetry on behalf of your company, as well as view and manage the list of your company’s CLA Managers for the CLA Group Cloud Native Computing Foundation (CNCF)."

This is incorrect; the added administrator has permissions over signers for the entire CNCF (which they should). Nor are there any specific permissions associated with the OpenTelemetry project.

Expected behavior

The email should have said:

"You have been added as a CLA Manager for the organization Red Hat, Inc. for the CLA Group Cloud Native Computing Foundation (CNCF)."

A clear and concise description of what you expected to happen.

Environment

Please complete the following information:

jberkus commented 2 years ago

This appears to be a more general bug where any email about our CNCF-level permissions gets attributed to OpenTelemetry instead. We just got another email:

This is a notification email from EasyCLA regarding the project OpenTelemetry.

q () has been removed as a CLA Manager from Red Hat, Inc. for the project OpenTelemetry.
WillsonHG commented 1 year ago

This has been added to our tracker and we will be investigating the issue.

mlehotskylf commented 2 months ago

@jberkus we believe this issue has been resolved. Can you please confirm this issue is no longer occurring? Thank you!

mlehotskylf commented 2 months ago

@jberkus please let us know, if no response in one week this ticket will be closed automatically. Thank you for understanding.

jberkus commented 2 months ago

I cannot verify it at this time, given that it requires adding or removing an administrator, something that we can only do when staffing is actually changing.

thakurveerendras commented 2 months ago

@mlehotskylf , @nickmango , The Issue is still reproducible as reported on the dev site. Kindly update the email text as mentioned in expected section above

image

jberkus commented 2 months ago

This is still broken.

I just had to remove an administrator today, and got the attached:

image

nickmango commented 2 months ago

Noted @jberkus . Will have this updated

nickmango commented 1 month ago

@thakurveerendras kindly verify this context is the cla_group_id has to be signed at the foundation level..(at least there has to be association between foundation and cla_group, which should be the case for the Sun project)

thakurveerendras commented 1 month ago

Tested on dev site & found that proper (parent) project name appears while added/deleted PM from enrolled child project

Refer to the screenshot

image image

nickmango commented 4 weeks ago

@jberkus this was resolved and tested internally.. Whenever you get an opportunity you can verify on your end. Thanks

jberkus commented 3 weeks ago

Will do. I can only test it by adding/removing an administrator, which is not something I can casually do without informing management.