communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

Administrator's console should JIT fetch data #3575

Open jberkus opened 2 years ago

jberkus commented 2 years ago

Summary

The administrator's console, displaying all approved contributors, should only fetch data in batches or according to search criteria, for better performance and more current data.

Background

  1. Log in as an organization administrator
  2. Go to the main dashboard (https://organization.lfx.linuxfoundation.org/foundation/****/cla)
  3. Wait up to 60 seconds while it loads

and:

  1. Two admins start two concurrent sessions
  2. One admin adds a contributor
  3. The second admin cannot see the contributor just added, since they are looking at in-browser cached data

Basically, when I view the console, all data in all tables is being 100% loaded from the backend. Not just the data I can see. Since I am highly unlikely to scroll through all contributors, this is a waste of time and bandwidth. Instead, the screen should just load the data required to display (basically the first 5 entries in each table) and should side-load if the user does decide to scroll. If the user does a search, that search should execute against the backend.

User Story

Acceptance Criteria

Data in display tables is side-loaded or retrieved based on searches as needed.

WillsonHG commented 1 year ago

Hello! @jberkus @mrbobbytables

First, I do want to apologize for the lack of response and communication on your issues here in this repo. Going forward, we will be working to prioritize the bug fixes and usability concerns you have reported with the CLA corporate console. Further, we’ll be closely monitoring this repo for any new issues raised by you or the wider community and will strive to respond in a timely manner.

I’m happy to report that we’ve already improved the loading time of the CLA Corporate Console by paginating the Approved List of Contributors section during a release in June of 2022. We will also now be adding pagination to the Contributor Acknowledgements (also) and the Event log section. Both of these enhancements will further improve the performance of the page.

For the concurrency issue, we do expect the user to refresh the page for new data if they have been in the dashboard for an extended amount of time. The enhancements to the remaining sections should make reloading the page less cumbersome.

I'll be labeling and organizing your open issues and you should see frequent status updates in them regarding the issues individually. Thank you!

mrbobbytables commented 1 year ago

Thanks @WillsonHG !

WillsonHG commented 1 year ago

@jberkus @mrbobbytables Unfortunately I don't have any new ETAs or updates to report for this week. We're currently working through some blockers for the FINOS project that have become rather urgent. https://github.com/communitybridge/easycla/issues/3773 https://github.com/communitybridge/easycla/issues/3779 We also have a GitLab issue that is currently blocking an LF Europe project https://github.com/communitybridge/easycla/issues/3537

The goal is to get those fixed next week, and then move onto the planned enhancements/fixes for the CLA corp console you've reported.

nickmango commented 4 months ago

@jberkus Kindly confirm the pagination aspect of this and if its sufficient to close this ticket. The auto update hasnt been implemented and the UI will need a manual refresh as described by Heather cc @mlehotskylf