communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

Contributor status not updated while PR automatic covered after add user under approval list on ecla without required ICLA case #4063

Open thakurveerendras opened 1 year ago

thakurveerendras commented 1 year ago

Summary

Contributor status not updated while PR automatically covered after adding user under the approval list on ecla without the required ICLA case

Steps

  1. Add cla group with not selected " Require corporate contributors to sign Individual CLAs "
  2. Add PR which CLA gated
  3. Go to the company cla page & add a GitHub user under the approval list

    Actual results

    User added under contributor list with "Not Authorized" status

    Expected behavior

    User should be added under the contributor list with "Authorized" status

Screenshots

image

umeshlumbhani247 commented 1 year ago

@thakurveerendras Working fine on my side, Can you please remove duplicate signatures if those are exists. May be due to duplicate signatures, this issue may occurs. CC: @mlehotskylf

mlehotskylf commented 9 months ago

@thakurveerendras can you please confirmed this has been tested? If yes then please change the status. Thanks!

thakurveerendras commented 9 months ago

Created new setup & testing is blocked due to the below issue

mlehotskylf commented 9 months ago

Blocker issue #4228 is in progress.

mlehotskylf commented 9 months ago

4228 is not fixed yet but @thakurveerendras can complete testing of this fix.

mlehotskylf commented 9 months ago

https://github.com/communitybridge/easycla/issues/4228 is also in QA Ready now.

thakurveerendras commented 9 months ago

Issue is still reproducible as reported on the dev site, image image

nickmango commented 9 months ago

@thakurveerendras could you give more details on this ? The cla-group in question . Did it have icla and ccla configured ? In addition what was the PR ? I need to be able to reproduce this

thakurveerendras commented 9 months ago

Kindly refer to the requested details

Project details:

mlehotskylf commented 9 months ago

This is corner case and lower priority so we can fix it in next release.