communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
62 stars 45 forks source link

Auto-Ecla: Contributors acknowledgment remain authorized after remove the user from the approved list #4325

Open thakurveerendras opened 1 month ago

thakurveerendras commented 1 month ago

Summary

Contributors acknowledgment remain authorized after remove the user from the approved list in auto-ecla case

Background

  1. Go to the org dashboard & login with valid credentials
  2. Add PR
  3. Enable Auto-Ecla toggle button
  4. Add the user email address under the approval list

Expected behavior

User should become unauthorized

Screenshots

image

thakurveerendras commented 1 month ago

Refer to PR for more details: https://github.com/sun-test-org/repo1/pull/115 image

thakurveerendras commented 1 month ago

On prod, added approval contributor not showing under the list, Kindly review Refer to the below details:

Link: https://organization.lfx.linuxfoundation.org/foundation/a092M00001IkZSNQA3/project/a092M00001IdwOGQAZ/cla

image

mlehotskylf commented 1 month ago

@thakurveerendras please confirm if this is regression issue. Thanks!

mlehotskylf commented 1 month ago

@thakurveerendras confirmed this is working fine in PROD but this is corner case.

mlehotskylf commented 1 month ago

To be completed by EOD today (May 23rd).

nickmango commented 1 month ago

@thakurveerendras kindly verify Tried with your user as this appeared to have been an issue with the ICLA check pass hence the Authorized state

Image

thakurveerendras commented 4 weeks ago

Issue is still reproducible at my end. Note that the user is under the ICLA list with a disabled state Refer below details

image image image

mlehotskylf commented 3 weeks ago

@nickmango to sync with @thakurveerendras on this.

nickmango commented 3 weeks ago

Highlighted 2 issues in the discussion with @thakurveerendras