communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

Co-authored-by checking fails unexpectedly #4329

Open ilrudie opened 6 months ago

ilrudie commented 6 months ago

Summary

When I accept suggestions by maintainers of the istio project it causes the easyCLA check for that commit to fail with a message:

The email address for the commit (https://github.com/istio/istio.io/commit/4f5e4666fb888f00678ef0a6900cf78ac3f4be3d) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Following the troubleshooting steps I do see both authors as valid "clickable" links to github profiles. The co-author's email address looks to be the same as his regular contributions to the project so the only thing I can figure is easyCLA isn't validating these co-authored entries correctly.

Background

Provide context to the issue - provide steps to reproduce the behavior, such as:

  1. Go to 'https://github.com/istio/istio.io/pull/15072#issuecomment-2117789295' to view the error. I will try to leave it up for a while but we do need to move the PR along at some point.

This was created by:

  1. Submitted a PR to istio/istio.io repo
  2. Receive and accept suggestions from a maintainer of the repository using the github PR web ui.

Expected behavior

I would expect suggestions from maintainers who have signed the CLA would not trigger a failure when their email becomes associated with the commit by addition of a "Co-authored-by" line in the commit message.

Screenshots

image

Environment

Please complete the following information:

jarias-lfx commented 6 months ago

Thank you for the report @ilrudie. I am adding additional PRs with the same issue:

svrnm commented 6 months ago

Thanks for raising this @ilrudie, we are facing the same issue with at least 2 issues:

jarias-lfx commented 6 months ago

Update: We have identified the root cause of the issue and decided to rollback the co-author changes to unblock the community, since the fix will take longer engineering time. The PR should update by adding /easycla comment, which I added the in the reported PRs and confirmed EasyCLA passing. Thank you for your patience.

svrnm commented 6 months ago

thanks @jarias-lfx

ilrudie commented 6 months ago

Thanks @jarias-lfx!