search

communitybridge / easycla

The Contributor License Agreement (CLA) service of the Linux Foundation lets project contributors read, sign, and submit contributor license agreements easily.
https://easycla.lfx.linuxfoundation.org
MIT License
64 stars 45 forks source link

PCC is not puling correctly the contributors list #4460

Open jarias-lfx opened 1 month ago

jarias-lfx commented 1 month ago

Summary

PCC is not pulling the contributor lists correctly, while the CLA Corporate Console does

Background

Project Admins to CLA Project Admins need to see the contributor listing in PCC to confirm the authorization. It seems there is a bug in PCC that is not listing all the contributors correctly.

Expected behavior

PCC should list all contributors as the CLA Corporate Console

Screenshots

See how for Google and FOCUS we have the following contributor and is confirmed in the DB

image

While in PCC the user is no where to be foundÑ

image

Environment

Please complete the following information:

mlehotskylf commented 4 weeks ago

This issue seem to be project specific because out test project in PROD is showing as expected in PCC.

jarias-lfx commented 4 weeks ago

ProjectID: 3c40a0e1-252b-4c08-bf02-72a38306216b Endpoint: https://pcc-bff.platform.linuxfoundation.org/production/api/cla-services/cla-group/3c40a0e1-252b-4c08-bf02-72a38306216b/contributors?companyID=40f2d23b-fd1e-4f5d-acc1-d9ed425adf54

jarias-lfx commented 4 weeks ago

PCC Ticket: https://github.com/linuxfoundation/lfx-pcc/issues/2896

nickmango commented 4 weeks ago

This happens to be a frontend issue . Upon reviewing pagination is not being handled on the PCC UI . Backend is sending a nextKey that can be used to fetch the next items once page limit is exceeded as shown below Initial call (returned count of 10 and total of 13 with next key value in the response) Image

Second call Image

thakurveerendras commented 4 weeks ago

Hello @nickmango CC: @amolsontakke3576

Please review the following backend cases that are reproducible. Frontend case is working fine and backend cases below are still reproducible.

  1. Wrong count appears, Refer below details
  1. Duplicate records listed under contributor

Refer screenshot for more details image

nickmango commented 4 weeks ago

Hello @nickmango CC: @amolsontakke3576

Please review the following backend cases that are reproducible. Frontend case is working fine and backend cases below are still reproducible.

  1. Wrong count appears, Refer below details
  • resultCount: 38
  • totalCount: 30
  1. Duplicate records listed under contributor

Refer screenshot for more details image

@thakurveerendras frontend needed to work on pagination. This explains why its working on corporate console but not PCC. Duplicate issue is another issue to fix however will work on that

nickmango commented 3 weeks ago

The PCC count of 30 is accurate and confirmed by the db records (An extra filter is used on PCC to ensure eclas are both signed and approved) Image For the corporate console (both authorized and non authorized users are returned) explaining a total score of 38 Image

thakurveerendras commented 3 weeks ago

Agree with you @nickmango

Updating this issue status by referring above comment, I will add a separate ticket for duplicate records issue if replicated on production after deployment of this issue changes

thakurveerendras commented 2 weeks ago

Tested the fix on production and found that it is working fine. So updating this ticket status

Refer to the screenshot image image