add test_type to TestDesc to compile on nightly rust

commure / datatest

Datatest -- data-driven test framework for Rust

Apache License 2.0

53 stars 15 forks source link

add test_type to TestDesc to compile on nightly rust #19

Closed cormacrelf closed 4 years ago

cormacrelf commented 5 years ago

Not sure if this should be more complicated, e.g.:

use if_rust_version to do what the unimplemented cfgs would do and enable test_type for those 6-day-old nightlies
add macro syntax for changing the test type? (probably not necessary)
update docs to reflect {usability with stable rust} not being itself stable?

Also obviously this is going to fail most tests

cormacrelf commented 4 years ago

Ok, so:

the new parse_opts location also needs papering over in the post_v139 feature
CI needs the feature enabled

It seems like a lot of work to paper over all the libtest API we use to keep the stable guarantee... what other changes is libtest undergoing? Are there going to be changes that will break the ability to provide the facade?

idubrov commented 4 years ago

Yeah... I've been waiting for https://github.com/rust-lang/rust/issues/50297 to happen, which would, hopefully, solve these woes.

idubrov commented 4 years ago

I think, clippy runs on stable so maybe it doesn't need that feature set?

cormacrelf commented 4 years ago

No, the clippy task is running on nightly.

idubrov commented 4 years ago

Thanks for doing the work!