fix for recent nightlies' TestOpts change

commure / datatest

Datatest -- data-driven test framework for Rust

Apache License 2.0

53 stars 15 forks source link

fix for recent nightlies' TestOpts change #30

Closed cormacrelf closed 2 years ago

cormacrelf commented 3 years ago

See https://github.com/rust-lang/rust/pull/81356. The filter: Option<String> field was changed to filters: Vec<String>.

cormacrelf commented 3 years ago

Clippy failure wise... yeah, it will fail on stable. It's using unstable nightly APIs that are different between nightly and stable, it literally cannot pass clippy stable. The other two problems are fixed in the other PR.

Edit: not now that I conditionally included the change using version_check.

cormacrelf commented 3 years ago

Ok, so a few updates:

I made it compile on stable as well by using version_check.
I think datatest is, by about rust 1.52, maybe going to stop working on stable. See build.rs for a note on that.
The last commit making test_case_registration the default is optional, I'm not sure if it is a breaking change or not. Probably not? The whole test suite passes with or without it. Maybe you didn't use it by default previously because that API might be a bit less stable than the ctor method. I've missed a bit but feel free to merge without it.

mverleg commented 3 years ago

Used this PR in my project and it solved the compile issue and runs the data-dependent tests successfully.

cormacrelf commented 3 years ago

I'll be sure to keep my main branch clean so that keeps working until this is merged.

eranrund commented 3 years ago

Hi! Any estimation on when this could get merged? Thanks!

mverleg commented 2 years ago

Thanks for merging