search

comntr / webext

An extension for Firefox and Chrome to add comments to any URL
https://addons.mozilla.org/en-US/firefox/addon/comntr/
211 stars 14 forks source link

icon styles not applied #9

Open atomGit opened 5 years ago

atomGit commented 5 years ago

comntr 1.3.1

strange - i updated to 1.3.1, set the icon colors in the settings and all was good, but soon after the styles/colors quit working - the icon is black all the time, yet clicking it reveals comments on, for example, the comntr AMO page

comntr commented 5 years ago

The colors are stored in chrome.storage.sync.set(...). I wonder if the storage is erased somehow. Also, the "sync" API apparently syncs something with other browsers. Perhaps we should switch to chrome.storage.local.set(...).

atomGit commented 5 years ago

i was wondering where settings are stored - i run a hardened config with FPI enabled, plus Site Bleacher auto-dumps some storage (IDB for one) on a domain basis so yeah, i bet the storage for comntr is getting dumped - all of my other extensions work fine, so wherever it is that most extensions store stuff seems to work - if i look at the folders in my profile, a lot of extensions are using /storage/default

comntr commented 5 years ago

What about uBO? Does it manage to keep its settings?

atomGit commented 5 years ago

yes how did you know i have uBO installed?

comntr commented 5 years ago

Someone who has more privacy extensions installed than I do, must surely have uBO :)