Revisions of the new_inh_model section

comob-project / snn-sound-localization

Training spiking neural networks for sound localization

https://comob-project.github.io/snn-sound-localization/

MIT License

57 stars 26 forks source link

Revisions of the new_inh_model section #115

Closed alberto-antonietti closed 4 weeks ago

alberto-antonietti commented 2 months ago

What does this PR do?

Revise the section new_inh_model

Why are we doing this?

Testing performed

Known bugs/limitations

alberto-antonietti commented 2 months ago

@francescodesantis we can work on this branch for revisions of the text.

thesamovar commented 2 months ago

Mention me in a comment when you're ready to merge!

alberto-antonietti commented 1 month ago

@francescodesantis there are some references to be added, I indicated them as TODO_REF.

alberto-antonietti commented 1 month ago

@thesamovar we have finished with this. Thanks!

thesamovar commented 1 month ago

Great! I'll try to take a look as soon as I can. Dan

From: Alberto Antonietti @.> Sent: 24 May 2024 18:49 To: comob-project/snn-sound-localization @.> Cc: Goodman, Daniel F M @.>; Mention @.> Subject: Re: [comob-project/snn-sound-localization] Revisions of the new_inh_model section (PR #115)

@thesamovarhttps://github.com/thesamovar we have finished with this. Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/comob-project/snn-sound-localization/pull/115#issuecomment-2129981315, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWE6PW5KEC335LBQFCHMM3ZD5VQFAVCNFSM6AAAAABHLGFQTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZHE4DCMZRGU. You are receiving this because you were mentioned.Message ID: @.***>

thesamovar commented 1 month ago

OK first impression:

There's a link in the contributor table that includes the words TODO so presumably not finished?
There's HTML code and hand numbered citations in the text. Please replace with MyST figure environments and MyST references. See the other markdown files (e.g. https://github.com/comob-project/snn-sound-localization/blob/main/paper/sections/basicmodel/basicmodel.md)
The main text you've added starts with a section titled TL;DR which probably isn't appropriate ;-) and ends with the word CONTUA on its own. I'm guessing not finished?
Confirm that the paragraph structure is correct? In Markdown you need a blank link between paragraphs.
Please add your code to the repository (it should all be available in one place).

Thanks!

francescodesantis commented 1 month ago

Hi @thesamovar, we've made the last changes to our section, including testing the notebook with the latest version of Nest, and it works!

thesamovar commented 4 weeks ago

Thanks! Merging now. There are a couple of minor issues remaining but probably easier if I just fix them! Thanks!