comocheng / ChemCheck

PyCanChemAndYouCan2! A tool to check chemistry, in the form of chemkin and cantera files.
Other
12 stars 4 forks source link

GSoC Draft Plan #8

Open 12Chao opened 5 years ago

12Chao commented 5 years ago

Hi @rwest , @bryanwweber This is a draft plan for the project, I leave last two weeks with no plan because I am not sure how long will it take for solving chemical errors( maybe we need a further discussion on it). I plan to get the website construction done before first evaluation period, and I am not sure if it is satisfied for your expectation, please let me know how do you think about the plan.

PS: I figured out how to handle the list view and working on using ajax to integrate ck2cti file.

bryanwweber commented 5 years ago

I have a few comments. Also tagging @kyleniemeyer and @decaluwe for their comments. My main concern is that I want to make sure there is at least one working, useful, feature, instead of 5 half-working, not-useful features. For instance, a site that just displays static, colored, HTML of the spot in a CK file with a syntax error and lets me upload a new file I fixed myself on my computer is more useful to me than one that lets me edit the file online but doesn't show me anything about where the error is.

Get website done

What does this mean? It is really broad, I could interpret "get website done" as finishing the project! Could you be more specific here?

solve syntax error

I'm not sure what this means either. Do you mean that you will try to automatically correct the problem? I think that would be too complicated for the first version of this website. I think the best thing to start with is just to have a nice interface to display the syntax error that ck2yaml has found, with coloring if possible. If the user can edit the file right on the website, that's great but not necessary as long as they can see the exact line in the file where the problem is.

Some other general comments:

kyleniemeyer commented 5 years ago

I agree with everything @bryanwweber said

decaluwe commented 5 years ago

Hi @12Chao -- I think this is a good framework for your work plan, but as @bryanwweber said, needs some more detail. In short, we should be able to read this work plan and very clearly decide if the timeline and objectives are being met.

In addition to @bryanwweber's comments, I would add the following:

  1. During evaluation weeks, I think there needs to also be parallel work objectives. I.e. to assume that the entire week would be spent "discuss[ing] with mentors" (as in July 22-26) is not very reasonable.
  2. For each objective, it would be great to have a little more detail on your priorities and objectives. What does it mean to "solve" an error? Will the checker "fix" the problem for the user, or just diagnose and give feedback/options to the user? If the latter, specifically what information should it provide?

I know it requires a good bit of thought, and it's okay if sometimes the answer is "I won't really know until I get there." 😆 But defining the criteria as specifically as possible will help guide your work and make it flow a lot easier, going forward.

Lastly, don't worry too much about getting the timing exactly right - we are allowed to update and edit the scope, as we move forward, so long as sufficient progress is made!

Again, this is a very good start - will look forward to seeing how it looks with a little more detail filled in!

12Chao commented 5 years ago

Thanks for your suggestions @bryanwweber @kyleniemeyer @decaluwe , I just revised the plan, and I will add more details as I move forward, especially for debugging script writing plan.

bryanwweber commented 5 years ago

Hi @12Chao Thanks for the update, I think this is a good place to go from now. Let's keep updating this issue as the schedule is updated in the coming weeks.

With the first evaluation next week, I'd like to set up a 15-30 minute video call for Friday (6/21) or Monday (6/24) so you can give us a demo of the site and the things you've completed so far. What is your schedule for those days @kyleniemeyer @decaluwe @rwest ?

rwest commented 5 years ago

Free Friday afternoon. At at conference Monday.

kyleniemeyer commented 5 years ago

I'm good all Friday (pacific time)

12Chao commented 5 years ago

I'm available on both days.

decaluwe commented 5 years ago

I'm also available both days. We have the NF call Friday morning (10 am eastern), right?

On Tue, Jun 18, 2019 at 8:56 AM Chao Xu notifications@github.com wrote:

I'm available on both days.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/comocheng/ChemCheck/issues/8?email_source=notifications&email_token=ABEC7PASFMNEEOULTBUATT3P3DZSPA5CNFSM4HYRSQ6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX65FJY#issuecomment-503173799, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEC7PDZ5WQ3WEKS5RYBNZDP3DZSPANCNFSM4HYRSQ6A .

bryanwweber commented 5 years ago

Yes, the NF call is 10 AM EDT. Let's say 1PM EDT on Friday? We can use my WebEx: https://uconn-cmr.webex.com/meet/bww09001 or another service of your choosing

decaluwe commented 5 years ago

Okay, so my schedule changed late yesterday, and I'm only available until 1 pm tomorrow - sorry. I think it's okay if you all want to go ahead without me, though.

Steven

On Wed, Jun 19, 2019 at 8:31 AM Bryan W. Weber notifications@github.com wrote:

Yes, the NF call is 10 AM EDT. Let's say 1PM EDT on Friday? We can use my WebEx: https://uconn-cmr.webex.com/meet/bww09001 or another service of your choosing

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/comocheng/ChemCheck/issues/8?email_source=notifications&email_token=ABEC7PFMLMIK5NRYYHYMMD3P3I7MZA5CNFSM4HYRSQ6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCB5FA#issuecomment-503586452, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEC7PEMIE4AMADD64BLJD3P3I7MZANCNFSM4HYRSQ6A .

kyleniemeyer commented 5 years ago

OK, I can join at that time on Friday.