search

comocode / laravel-ab

Laravel 5 A/B experiment testing using with Blade
https://packagist.org/packages/comocode/laravel-ab
MIT License
31 stars 14 forks source link

AbMigrate.php:36 - hasOption() Causes ab:migrate to Fail #13

Open AlteranAncient opened 7 years ago

AlteranAncient commented 7 years ago

When trying to run ab:migrate on a Laravel 5.1.45 project, the following error is generated:

[Symfony\Component\Debug\Exception\FatalThrowableError]
  Call to undefined method ComoCode\LaravelAb\App\Console\Commands\AbMigrate::hasOption()

Removing line 36 from AbMigrate then allows the artisan command to run as expected.

I might also point out that trying to run the migrations in this way, as opposed to using vendor:publish means that this package does not work with any existing deployment pipelines that a developer may have already configured.

82rules commented 7 years ago

thank you for the heads up. I will look into making that change, if you want to submit a PR on it I'd also appreciate it.

82rules commented 7 years ago

@AlteranAncient or anyone else, I havent had any time to submit a PR against this. If anyone would like to take a stab at this I would appreciate it.