New instance created each time

comocode / laravel-ab

Laravel 5 A/B experiment testing using with Blade

https://packagist.org/packages/comocode/laravel-ab

MIT License

31 stars 14 forks source link

New instance created each time #6

Closed DODMax closed 8 years ago

DODMax commented 8 years ago

Hey, great package.

Somehow duplicated instances are created on each visit for me (one new row in ab_instance each visit with the same instance value) therefore no tracking really happens.

This commit fixed it for me: https://github.com/darekwalega/laravel-ab/commit/40f4a14264ff792697caae96781f595422e01be2

DODMax commented 8 years ago

I guess the proper fix would be to store NULL instead of serializing null while saving Instance. This should fix it: https://github.com/comocode/laravel-ab/pull/7

82rules commented 8 years ago

Took me a while to see the issue and fix, appreciate the contribution!