search

comolo / contao-supertheme

SuperTheme is the best way to use SCSS, JS, CoffeeScript with Contao CMS.
7 stars 2 forks source link

tl_layout conflict #12

Closed reluem closed 8 years ago

reluem commented 8 years ago

The DCA config of contao-supertheme and cliffparnitzky/TinyMceFontAwesome are somehow interfering!

// Add external_js + external_scss $GLOBALS['TL_DCA']['tl_layout']['palettes']['default'] = str_replace( array(',script;', 'stylesheet,external;', 'stylesheet,external,'), array(',script,external_js;', 'stylesheet,external,external_scss;', 'stylesheet,external,external_scss,'), $GLOBALS['TL_DCA']['tl_layout']['palettes']['default'] );

interferes with

$GLOBALS['TL_DCA']['tl_layout']['palettes']['default'] = str_replace('external', 'external,tinyMceFontAwesome', $GLOBALS['TL_DCA']['tl_layout']['palettes']['default']);

Thus, only the fontawesome-input is visible and the external_js field is hidden/overwritten.

Any proposals for a local dcaconfig change for this issue?

contao 3.5.6 "comolo/contao-supertheme": ">=2.2.5.0,<2.3-dev", "cliffparnitzky/tiny-mce-font-awesome": ">=2.0.0.0,<2.1-dev",

I also created a ticket here: https://github.com/cliffparnitzky/TinyMceFontAwesome/issues/4

comolo commented 8 years ago

The following code change solves the issue. Would be great if the maintainers of "tiny-mce-font-awesome" could apply it. @cliffparnitzky $GLOBALS['TL_DCA']['tl_layout']['palettes']['default'] = str_replace('external', 'external,tinyMceFontAwesome', $GLOBALS['TL_DCA']['tl_layout']['palettes']['default']); to $GLOBALS['TL_DCA']['tl_layout']['palettes']['default'] = str_replace(array('external,', 'external;'), array('external,tinyMceFontAwesome,', 'external,tinyMceFontAwesome;' ), $GLOBALS['TL_DCA']['tl_layout']['palettes']['default']);

Anyway you should update SuperTheme to the latest realese (2.3) for an improved stability.