comonicon / Comonicon.jl

Your best CLI generator in JuliaLang
https://comonicon.org
MIT License
282 stars 25 forks source link

generate batch script entryfile for windows #241

Closed johnnychen94 closed 1 year ago

johnnychen94 commented 1 year ago

This doesn't fix every issue I've met when using Comonicon on Windows, but I believe it's a good first step.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 19.04% and project coverage change: -1.30 :warning:

Comparison is base (63c46c0) 82.84% compared to head (9e7b362) 81.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #241 +/- ## ========================================== - Coverage 82.84% 81.55% -1.30% ========================================== Files 21 24 +3 Lines 1586 1610 +24 ========================================== - Hits 1314 1313 -1 - Misses 272 297 +25 ``` | [Impacted Files](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/builder/install.jl](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J1aWxkZXIvaW5zdGFsbC5qbA==) | `61.45% <19.04%> (-13.21%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/241/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Roger-luo commented 1 year ago

I'm good to merge this PR since it's not breaking any CIs, I'm wondering what you think would be the next step? e.g how should people add this to their path on windows?

johnnychen94 commented 1 year ago

I'm wondering what you think would be the next step? e.g how should people add this to their path on windows?

In Powershell we can use

[System.Environment]::SetEnvironmentVariable('PATH', $env:USERPROFILE + '\.julia\bin;'+$Env:Path, [System.EnvironmentVariableTarget]::User)

should I add this to the documentation?

To modify the PATH manually, one can follow this instruction.

johnnychen94 commented 1 year ago

bump @Roger-luo