comonicon / Comonicon.jl

Your best CLI generator in JuliaLang
https://comonicon.org
MIT License
282 stars 25 forks source link

bugfix(windows): handle cmd call error #245

Closed johnnychen94 closed 1 year ago

johnnychen94 commented 1 year ago

The current batch script provided by #241 unconditionally returns 0 because there is an endlocal line at the end. This patch fixes it by checking julia exit code and handles it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -23.53 :warning:

Comparison is base (73774f4) 24.35% compared to head (b52cd6b) 0.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ========================================== - Coverage 24.35% 0.82% -23.53% ========================================== Files 20 20 Lines 1581 1573 -8 ========================================== - Hits 385 13 -372 - Misses 1196 1560 +364 ``` | [Impacted Files](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/builder/install.jl](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J1aWxkZXIvaW5zdGFsbC5qbA==) | `0.00% <ø> (-58.34%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/comonicon/Comonicon.jl/pull/245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.