search

comonicon / Comonicon.jl

Your best CLI generator in JuliaLang
https://comonicon.org
MIT License
282 stars 25 forks source link

fix: brief appended to intro by mistake #250

Closed xukai92 closed 1 year ago

xukai92 commented 1 year ago

brief has been appended to the end of intro by mistake this pr fixes this

bug screenshot (see the selected part): image

Roger-luo commented 1 year ago

Good catch thanks! Just need to wait for CI pass.

FYI the Julia version of Ion has been abandoned see also https://discourse.julialang.org/t/ann-the-ion-command-line-for-julia-developers-written-in-rust/94495/1

codecov[bot] commented 1 year ago

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/ast/printing.jl 0.00%

:loudspeaker: Thoughts on this report? Let us know!.

xukai92 commented 1 year ago

FYI the Julia version of Ion has been abandoned ...

Thanks for pointing this out. I was checking Ion.jl mostly to make sure what I saw in my own CLI project with Comonicon was really bug (that also appears in another CLI project) but not something I did wrong.

xukai92 commented 1 year ago

is the failed CI related to my PR? i tested it locally with the main branch and see the same error in CI.

Roger-luo commented 1 year ago

Indeed seems due to #244 not updating the printing tests, I'll merge this one first