search

comonicon / Comonicon.jl

Your best CLI generator in JuliaLang
https://comonicon.org
MIT License
282 stars 25 forks source link

Fix printing of Vararg on Julia 1.7 #262

Open jakobnissen opened 10 months ago

jakobnissen commented 10 months ago

Recent versions of Julia has moved Vararg from being a Type to being its own thing. This means it will error if T is a vararg and you try to do isa to <: operations with it. This caused an error, which is fixed here by explicitly testing if T is a Vararg.

Fixes #261

Note that THIS IS NOT TESTED! I couldn't figure out how to write a test for this.

Roger-luo commented 10 months ago

could you just copy-paste the example from that issue in the test? that should be sufficient as a test

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/ast/printing.jl 84.69% <80.00%> (+84.69%) :arrow_up:

... and 22 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.