comotion / security.vcl

protect your websites with varnish rules
GNU General Public License v2.0
193 stars 39 forks source link

problems using makefile #1

Closed beorn- closed 13 years ago

beorn- commented 13 years ago

Hello,

I have tried to use the Makefile provided in the git repository. And some tops blocks the generation check_variables script.

I have a patch handy if you like.

Regards,

Aurélien

comotion commented 13 years ago

actually, sure why don't you post your patch? from what I can tell it's the check_variables script that is braindead, so I'd be curious to see what your solution is,

ccastro commented 13 years ago

i got this error:

make Variable X-SEC-Client){ found in a module, but not in VARIABLES! Unsafe. handlers.vcl: if(!req.http.X-SEC-Client){ # this variable always present, so rule always false main.vcl: if(req.restarts == 0 && req.http.X-SEC-Client){ Variable X-SEC-Response) found in a module, but not in VARIABLES! Unsafe. main.vcl: if(req.http.X-SEC-Response){ main.vcl: if(obj.http.X-SEC-Response){ main.vcl: if(!req.http.X-SEC-Response) { Variable X-SEC-Response){ found in a module, but not in VARIABLES! Unsafe. main.vcl: if(req.http.X-SEC-Response){ main.vcl: if(obj.http.X-SEC-Response){ make: *\ [check] Error 1

then i just edit main.vcl and handlers.vcl change:

if(obj.http.X-SEC-Response){

for:

if(obj.http.X-SEC-Response ){

And it works!! :D

$ make Generating build/variables.vcl: done Check passed: No unknown variables found

But i dont know if this is normal:

$ make ruletest Rule positive testdemo-1 FAILED Rule negative testdemo-1 Ok

Any hint?

ccastro commented 13 years ago

Can't make it work on FreeBSD :( any hint?

comotion commented 13 years ago

9a08009 fixes this issue.

ccastro: please let us know what's wrong on FreeBSD by creating a new issue and describing what's wrong.

vlpeng commented 12 years ago

Hi there, I encountered the same issue here. How I can let my Varnish recognize these VARIABLES while make? Or else I have completed make install? Could you advise? Thanks.

root@ubuntu:~/security.vcl/vcl# uname -a Linux ubuntu 3.0.0-12-server #20-Ubuntu SMP Fri Oct 7 16:36:30 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux root@buntu:/var/log/varnish# varnishd -V varnishd (varnish-2.1.5 SVN ) Copyright (c) 2006-2009 Linpro AS / Verdens Gang AS

root@ubuntu:~/security.vcl/vcl# make ruletest bash: line 1: GET: command not found Rule positive testdemo-1 FAILED bash: line 2: GET: command not found Rule negative testdemo-1 Ok root@ubuntu:~/security.vcl/vcl# make Check passed: No unknown variables found root@ubuntu:~/security.vcl/vcl#

comotion commented 12 years ago

Hi. The issue you describe does not correspond to the issues ccastro was having.

make ruletest requires the perl program and library libwww which should be available through FreeBSD ports, which you seem to be missing.

In addition, newest releases of Security.VCL have been ported to Varnish 3.0. The consequence of this is we no longer support varnish 2.1, you must upgrade to Varnish 3.0.

vlpeng: we care about supporting FreeBSD, however if you have issues please create a new issue rather than post on closed unrelated issues.