search

comozilla / onigo-server

3 stars 4 forks source link

fixed #22 orbMapをdashboard.jsからも使うように #26

Closed shundroid closed 8 years ago

shundroid commented 8 years ago

This change is Reviewable

dadaa commented 8 years ago

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

_dashboard.js, line 120 [r1] (raw file):_

Dashboard.prototype.removeOrb = function(name) {
  const orbNames = this.orbMap.getNames();
  if (orbNames.indexOf(name) === -1) {

has メソッドは使わない？

Comments from Reviewable

shundroid commented 8 years ago

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

dashboard.js, line 120 [r1] (raw file):

Previously, dadaa wrote… > has メソッドは使わない？ >

そうでした。直します！

Comments from Reviewable

dadaa commented 8 years ago

Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable