comozilla / onigo-server

3 stars 4 forks source link

Simple command #36

Closed shundroid closed 8 years ago

shundroid commented 8 years ago

This change is Reviewable

dadaa commented 8 years ago

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


commandRunner.js, line 27 [r1] (raw file):

      rotateFunction();
    },
    stop: (config) => {

ここのカッコはいらないかな


commandRunner.js, line 106 [r1] (raw file):

        return Math.floor(Math.random() * (arg.args[1] - arg.args[0])) + arg.args[0];
      case "randomInArray":
        return arg.args[0][Math.floor(Math.random() * arg.args[0].length)];

ここは配列の箱を用意するだけで良いです?


Comments from Reviewable

shundroid commented 8 years ago

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


_commandRunner.js, line 27 [r1] (raw file):_

Previously, dadaa wrote… > ここのカッコはいらないかな >

はずします!


commandRunner.js, line 106 [r1] (raw file):

Previously, dadaa wrote… > ここは配列の箱を用意するだけで良いです? >

arg.args[0] に配列が入ってきて、それの中でindexをランダムにして取り出しています。


Comments from Reviewable

dadaa commented 8 years ago

Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable