bugfix for random ordering of variables in x-vector

comp-imaging / ProxImaL

A domain-specific language for image optimization.

MIT License

114 stars 29 forks source link

bugfix for random ordering of variables in x-vector #36

Closed wiedemannc closed 7 years ago

wiedemannc commented 7 years ago

Iterating over the python dictionary id2copy was changing the order of the variables randomly (there is no guarantee that the iterating order is equal to the insertion order). Removing the extra loop and integrating everything into the main loop fixed the issue.

EDIT: Not sure why the continuous integration build has failed, I assume it is not related to this PR?

SteveDiamond commented 7 years ago

This looks good! The build failure was do to an unrelated issue, now fixed.