comp-imaging / ProxImaL

A domain-specific language for image optimization.
MIT License
114 stars 29 forks source link

Major overhaul of ProxImaL #49

Closed antonysigma closed 4 years ago

antonysigma commented 4 years ago

Changelogs:

antonysigma commented 4 years ago

This change also solves #41, #44, #48, #30 and #33. Comments are welcome.

SteveDiamond commented 4 years ago

This is incredible! Will comment as much as I can, but I don't really know much about Halide (Felix handled that part). Very happy to merge this (after comments of course).

SteveDiamond commented 4 years ago

Can you comment on "This change cripples the CUDA engines". What functionality are we losing exactly?

antonysigma commented 4 years ago

Can you comment on "This change cripples the CUDA engines". What functionality are we losing exactly?

I meant those pycuda specific device-host data transfer intrinsic in the module proximal.algorithms.pock_chambolle, namely the following lines of code:

Actually I didn't mean to remove the code. I have now reverted most of them back. The only catch is that Travis CI cannot spawn a GPU machine to test the project. Please feel free to review pock_chambolle.py.

SteveDiamond commented 4 years ago

Ok, it looks fine to me. Should I merge this in?

antonysigma commented 4 years ago

@SteveDiamond Yes please. Thank you very much!

In the meantime, I am working on another draft PR to update test_poisson.py and test_mask.py. I will ping you when I am ready.