search

comp-physics / RBC3D

3D Spectral boundary integral solver for cell-scale blood flow
MIT License
7 stars 3 forks source link

Readme Update #26

Closed suzanmanasreh closed 3 months ago

suzanmanasreh commented 3 months ago

I committed some things a few months ago that I don't think are necessary for the repo anymore, so this PR removes them. I've checked the code still compiles.

sbryngelson commented 3 months ago

examples/README.md seems somewhat useful (though I can imagine it being better); what's the motivation for removing it?

suzanmanasreh commented 3 months ago

2 reasons. I wanted to create better images of the example cases with ray-tracing, but I don't have those yet and not sure when I will. The other part I don't like though is that the timestep sentence is incorrect and not explained well, so I thought of just removing it.

A better solution would be to add a simple example case the shows the adjusted timesteps for wbcs and point people to that for wbcs and case_diff_celltypes for sickles instead of listing timestep values directly, but I'm not sure if that would bloat the repo further.