comp-physics / RBC3D

3D Spectral boundary integral solver for cell-scale blood flow
MIT License
7 stars 3 forks source link

Phoenix Runner #41

Closed suzanmanasreh closed 3 weeks ago

suzanmanasreh commented 4 weeks ago

All the updates in this PR:

sbryngelson commented 4 weeks ago

please rebase so there aren't so many commits

suzanmanasreh commented 4 weeks ago

i took out the the line that lets you see a PR's commits on master but okay i'll try. the commit history on this is really complicated from having to add and remove my own cases.

sbryngelson commented 4 weeks ago

this has commits from 3 weeks ago?

suzanmanasreh commented 4 weeks ago

yeah i basically kept the same branch that i made other PRs from but ran a "git merge master" after pulling the PR onto master and never started a new branch, so the real differences start after #8ec18f5. sorry this is so hacky, i'm trying to resolve conflicts in the rebase now, but there's conflicts in all 96 commits, so it's too cumbersome.

suzanmanasreh commented 4 weeks ago

I just reset the commit history. Some of the Makefiles on the branch might look old, but that was because I gave all the case files unique names, so a global Makefile wasn't gonna work anymore without some wildcards. I'm hoping Makefiles can be completely removed in the future though if I'm happy with cmake. It handles everything pretty dynamically, but if you need a better explanation of the system I set up, I can try!

suzanmanasreh commented 4 weeks ago

Maybe someone else could help with the review if they're familiar with cmake? It's pretty much identical to Makefile.in and PETSc's official cmake.

suzanmanasreh commented 3 weeks ago

@sbryngelson look Phoenix runner works! I'm not putting a MacOS runner in the same PR though cause there's already too much here. The CMake works on Mac too though.