search

comp-physics / RBC3D

3D Spectral boundary integral solver for cell-scale blood flow
MIT License
7 stars 3 forks source link

ICE Runner #44

Closed suzanmanasreh closed 1 week ago

suzanmanasreh commented 1 week ago

Changes in this PR:

I module loaded netcdf-c and hdf5 on ICE and used that to build netcdf-fortran. Building netcdf-fortran myself was pretty tough, but I believe my instructions work for a shared library.

I also noticed that my tests really aren't comprehensive. The compile steps might be passing but it can still throw link errors at run-time. I handled this in the CMakeLists.txt (lines 105-108), and it runs without errors on my ICE account, but I'm not sure about other accounts. Tests should probably run code too. Seems like a separate issue that someone should open though.

This commit says 100+ lines added, but it's mostly duplicated code. Obviously, there needs to be a top-level install script that can call shell code or cmake to install whatever's necessary for each computer, but that's a lot of restructuring that I will leave for the future.

suzanmanasreh commented 1 week ago

@sbryngelson is it okay to leave this PR as an ICE runner fix only? Manually installing netcdf-fortran on mac is giving me too much trouble.

sbryngelson commented 1 week ago

Yes and it's useful to have Mac but you could do Ubuntu also, which might be helpful to get started. you can use a virtual machine on your Mac if needed.

suzanmanasreh commented 1 week ago

Thanks! I would use docker, but my computer doesn't have enough memory to run it without crashing. I'll see if another VM can take up less resources though.