search

comp345 / risk-game

Warzone game on console implemented using C++
1 stars 0 forks source link

Bug in Territory::getOwner => this affects GameEngine part 3 and the StartUp #26

Closed eyeshield2110 closed 2 years ago

eyeshield2110 commented 2 years ago

When fixing the GameEngine main game loop, there's a bug when adding territories to the players (in a test function, and not in the real start up). The method Territory::getOwner should not assign a territory to the player. image

Modification done: Removed the line p->addTerritories({this}); TODO: The startUp needs refactoring before merging with the main game play method.

eyeshield2110 commented 2 years ago

See code review in the PR #24

laila-chammaa commented 2 years ago

good to close?

eyeshield2110 commented 2 years ago

good to close?

yes