Adding LoggingObserver - Githubissues

comp345 / risk-game

Warzone game on console implemented using C++

1 stars 0 forks source link

Adding LoggingObserver #7

Closed laila-chammaa closed 2 years ago

laila-chammaa commented 2 years ago

what will need to get done as other parts get added/updated:

make command+commandProcessor subclasses of the Subject and ILoggable
implement the TODOs in "stringToLog"
add the notify(this) to a couple more places (specifically the command processor + Engine)
should it only be used in the logging driver or should the main loops have it too?

laila-chammaa commented 2 years ago

the TODOs will be implemented once I have a better idea of the effect of each order "when an order is executed, output the effect of the order to the log file"

laila-chammaa commented 2 years ago

LGTM! We should merge it into the branch a2 instead of a1 : I think it's better to keep a1 intact.

yea, wont merge until a2 is created, just wanted to have a good diff

eyeshield2110 commented 2 years ago

LGTM! We should merge it into the branch a2 instead of a1 : I think it's better to keep a1 intact.

yea, wont merge until a2 is created, just wanted to have a good diff

I've created a copy of a1 (a1_archived): this branch is safe to merge My current changes don't overlaps the modification you made when implementing the Observer pattern, so it's good to go.