comp500 / BorderlessMining

A windowed borderless (fullscreen) mod for 1.15.2 and newer versions of Minecraft
https://www.curseforge.com/minecraft/mc-mods/borderless-mining
MIT License
122 stars 35 forks source link

Update to 1.21 #112

Open sky-is-winning opened 5 months ago

sky-is-winning commented 5 months ago

Updates to MC v1.21 (fix #111)

Also: Update gradle to v8.8 Update fabric-loom to v1.6.12 Update fabric-api to 0.100.1+1.21 Update Java version to 21

Here's the compiled jar file.

sky-is-winning commented 5 months ago

Note: The game still crashes when you select the options menu if Iris is also used.

sky-is-winning commented 5 months ago

Fix the crashing when Iris is used by disabling FullScreenOptionMixin and FullScreenOptionMixin if Iris is present. Unless #97 is implemented, these do nothing when Sodium is present anyway (and Sodium is required for Iris to work)

sky-is-winning commented 5 months ago

Here's the new compiled jar.

uurha commented 4 months ago

Just tested jar mentioned above - it's working) Thanks @sky-is-winning

he3als commented 3 months ago

Works

Sovietsupporter69 commented 3 months ago

I'm still getting a crash when opening the options menu, what would you need from me to find the problem? I am using the new jar mentioned 3 posts above and don't have iris so its not that. image crash-2024-08-19_18.49.26-client.txt

sky-is-winning commented 3 months ago

@Sovietsupporter69

I'm still getting a crash when opening the options menu, what would you need from me to find the problem? I am using the new jar mentioned 3 posts above and don't have iris so its not that.

It's probably a different mod (in this case, enhancedblockentities) that also modified the mixin. Due to my bodged update of the mixin class, it leads to incompatibility with many mods which have a similar function of modifying the video options screen. In this case, I reccommend that you instead use Cubes Without Borders which does the same thing as this mod but has a proper update to 1.21 by someone who actually knows what they're doing. Might try and fix this if I get bored though :3

Sovietsupporter69 commented 3 months ago

@sky-is-winning Thanks for pointing me to a similar mod, wish I knew this other mod existed sooner cause it would've saved me so much time.

Longie520 commented 3 weeks ago

Works perfectly on 1.21.2 & 3 too! Though needed to ignore the version dependency in fabric-loader-dependencies.json first.

Thanks for this - hope this PR get merged soon