comp500 / BorderlessMining

A windowed borderless (fullscreen) mod for 1.15.2 and newer versions of Minecraft
https://www.curseforge.com/minecraft/mc-mods/borderless-mining
MIT License
120 stars 36 forks source link

Snip and Sketch incompatibility #25

Open Scarlaid opened 2 years ago

Scarlaid commented 2 years ago

I'm currently using the lastest Borderless Fullscreen a.k.a v1.1.1 Whenever I wanna take a screenshot using Snip & Sketch (hotkey is Windows + Shift + R), normally it would show the toolbar on middle top with a "plus" mouse cursor, instead it kinda overlapped For tabbing in and out, the screen flashed for a split second

Here's the video: https://streamable.com/xlzrb4 (to recognize the flashing screen, look at my mouse which flashed for a split second)

If these ain't bugs then I'm sorry for bothering 👀

comp500 commented 2 years ago

Could you try the test build in https://github.com/comp500/BorderlessMining/issues/19?

Scarlaid commented 2 years ago

Could you try the test build in #19?

I tried the test build, the one problem I encountered is somehow my monitor refresh rate downgraded to 60hz, originally was 75hz

I don't know if this the mod fault since my screen meant to be 60hz but I overclocked it to 75hz
comp500 commented 2 years ago

Try setting your refresh rate to 75Hz in the Windows settings: https://support.microsoft.com/en-us/windows/change-your-display-refresh-rate-in-windows-c8ea729e-0678-015c-c415-f806f04aae5a as the test build isn't forced into exclusive fullscreen anymore (assuming it's working) it will use the refresh rate you have configured for your Windows desktop. If changing that still doesn't work, let me know what hardware and driver versions you're using.

Scarlaid commented 2 years ago

Did exactly what the support link said and it does not put me in 75hz while having Minecraft in Borderless Fullscreen The display settings said 59hz (which is 60hz becuz windows is weird) after I go both fullscreen and windowed afterward But when I get in the display adapter properties it's still 75hz

I decided to use my phone to record exact issue I'm facing, here's the video: https://streamable.com/1kcrvm

Here are the specs

comp500 commented 2 years ago

Hmm, it looks like the game is requesting a 60Hz refresh rate display mode... could you check in the video settings what the "Fullscreen Resolution" slider says? If you're using Sodium, you'll need to press Shift+P to see the vanilla menu with this slider.

For Borderless Fullscreen to work properly, it should be set to "Fullscreen Resolution: Current". If that still doesn't work, check if there are other options in that slider mentioning 75Hz (i.e. "1366x768@75 (24 bit)") and try them.

Scarlaid commented 2 years ago

The "Fullscreen Resolution" it's always in "Current" state because I don't really bother changing it, as said "High performance impact". I did check around the slider for my resolution "1366x768@75 (24bit)" but the best it could support is "1366x768@60 (24bit)".

Here's another video to detail the issue: https://streamable.com/jwamvu

My guess for this is somehow Minecraft is now forced to use the meant to be supported refresh rate that the monitor offers, not the refresh rate that I overclocked it, though, going back to the v1.1.1 of Borderless Fullscreen, the overclocked refresh rate "1366x768@75 24bit" runs fine 🤔

I did try to disable NVIDIA ShadowPlay afterward but it did nothing

comp500 commented 2 years ago

Does "1366x768@75 (24bit)" show up in the menu with 1.1.1 installed? Also try without any mods installed... I'm not sure why it doesn't show up. It might also be worthwhile checking the NVIDIA Control Panel "Change resolution" section; that should show you all the display modes you have available to applications. It could be a bug in the GLFW/Minecraft window handling code, or Windows might not be listing the display mode for some reason...

Scarlaid commented 2 years ago

Only Sodium, Sodium Extra for the resolution settings, SodiumOption run with Borderless Mining Neither give me the supported "1366x768@75 (24bit)" But, the current version does not overwrite the resolution normally, but if I drag down the resolution bar in Vanilla settings (Shift+P), now both the settings will be in "Current" state, it will eventually overwrites the current resolution im having. Going back to the "Borderless Fullscreen" state (in 1.1.1 you did provide in the mod the option to put this as in the slide bar) just works fine Unlike Dev release, it just overwites instantly

Dev release: https://streamable.com/4lc52q
Current release: https://streamable.com/ukp082

For the NVIDIA "Change resolution", I said above is I overclocked the monitor to run 75hz Picture below is the available supported resolutions image

comp500 commented 2 years ago

I'm going to split this issue as there are 2 different problems being tracked here :P