search

comp500 / BorderlessMining

A windowed borderless (fullscreen) mod for 1.15.2 and newer versions of Minecraft
https://www.curseforge.com/minecraft/mc-mods/borderless-mining
MIT License
122 stars 35 forks source link

Sodium Support #80

Closed NulledBird closed 8 months ago

NulledBird commented 1 year ago

Adds a page to Sodium's video settings that allows modifying of most (read below) settings in the Mod Menu config.

Due to the way sodium's options work, there are no things like input boxes, but rather things like sliders. For this reason, things like the choosing the monitor are not available in the settings, as that would require building a custom option, and Sodium's documentation on this are little to none (I worked off looking at other mods that have Sodium compatibility).

I thought about adding in the full screen resolution option in, but since that is a vanilla option, sodium could implement this in the future, and so I decided to hold off on adding it.

Madis0 commented 1 year ago

Just to be clear, is this built with Sodium 0.4.10 or 0.5 in mind?

NulledBird commented 1 year ago

@Madis0 it should work with any sodium version (as long as the sodium itself doesn't change its file structure or any apis)

However, Sodium won't do that because they know that many mods will have to make major code base changes

So yes, it should work with 0.5 even though it was coded with 0.4

Madis0 commented 1 year ago

Well, Sodium 0.5 just did breaking changes, but perhaps not that many in the UI then.

NulledBird commented 1 year ago

Well, Sodium 0.5 just did breaking changes, but perhaps not that many in the UI then.

Just checked, it seems that it works fine. Looking at the change log, it was just mostly rendering changes, and nothing to do with the gui.

widegeon commented 9 months ago

how do i make this work?

NulledBird commented 8 months ago

Use the updated one by @UltimatChamp

It's much better and works