comp500 / BorderlessMining

A windowed borderless (fullscreen) mod for 1.15.2 and newer versions of Minecraft
https://www.curseforge.com/minecraft/mc-mods/borderless-mining
MIT License
122 stars 35 forks source link

BorderlessMining has issues on startup & with prntscr programs when using multiple monitors. #87

Open PlayfulPiano opened 1 year ago

PlayfulPiano commented 1 year ago

MC Version: 1.18.2 Borderless Mining Version: v1.1.2

This isn't a major bug in that it isn't fixable manually, but it is an annoyance to have to deal with it on startup every time.

Basically I am using a laptop monitor that is also connected to an external monitor via HDMI, allowing me to have dual monitor support via window 10's "Extend" setting for monitor projection.

On startup, with minecraft already set to fullscreen (borderless), the game's position is stuck between both monitors, causing the visual issues shown below.

image image

This is easily fixable manually by simply toggling the fullscreen button (f11) twice, putting it onto one monitor without issue (and then I can move it manually using win+shift to move it to my other monitor). But obviously it's an annoyance that would be beneficial to fix in the mod. I believe patcher's borderless fullscreen method doesn't have this issue, so it might be a good idea to check how they do their version of borderless fullscreen (even though it's mainly for older minecraft versions). I also tried setting the monitor in borderless mining's config to the second monitor, but it still causes the same issue. The only difference is what monitor the game goes to after pressing f11 twice.

image

The second issue I've discovered, also regarding multiple monitors, is that when I'm using prntscr while in minecraft, I experience issues on taking an actual snapshot of the game if the game is on my second monitor with borderless mining. The first screenshot here is of me doing a prntscr of my second monitor while the game is in fullscreen. image The second screenshot here is what screen I actually was on when I did the first prntscr. image

It seems to maybe be some cache issue for some reason, where borderless mining is taking screenshots of past visuals of the monitor. That or maybe there is still some remnants of standard fullscreen mechanics causing a resolution issue leading to this problem. It's also only a problem on the external monitor, not my laptop monitor.

Let me know if you need any other information, if it might help out.

MysticMia commented 9 months ago

Same printscreen issue here except I use a secondary monitor as primary: I set windows to display only the second monitor. It seems to lag behind. This is also noticeable when switching between tabs; you get a frame of the instance before your last, when you unfocused. The same bug probably also causes the effect that keybings for things like zoom do not get captured correctly.

Testing this on single monitor made it work fine without issues. Screenshots work as expected. Switching back in the same instance resulted in a frozen app, but using narrator it seems the game was still functional, letting me browse through menus and even change resolutions (but to no avail). Restarting Minecraft (on my second (showing only second) monitor) made it work as normal again. This test was executed with a whole bunch of other fabric mods with the quilt launcher (profile) and fabric API, on 1.20.4 with the 1.20.2 mod installed (1.1.9).