search

comp500 / ScreenshotToClipboard

Screenshots taken are copied to the clipboard.
https://www.curseforge.com/minecraft/mc-mods/screenshot-to-clipboard
MIT License
33 stars 1 forks source link

Added "copy" button #9

Closed TheNathanSpace closed 3 years ago

TheNathanSpace commented 4 years ago

Hello! I saw that you seem really friendly and active, so I figured I'd give this a shot...

The 1.8 mod Vanilla Enhancements had an improved screenshot chat message, letting you choose to copy it to clipboard. I wanted this functionality in 1.15, and I found your mod.

I spent some time adding this sort of functionality to your Forge 1.15 version (hooray for open-source!)—you can see what it looks like below. I was originally going to keep it for myself because I didn't want to distribute your code, but maybe you might be interested in it.

I'm not a professional programmer—I'm a self-taught hobbyist and don't have a ton of experience. I feel like storing the image and event in variables (like I did) isn't the best solution, but it only stores one at a time, so I can't imagine it's that big of a deal. If you want to take a stab at it and find a better way be my guest! Also, it can only copy the latest screenshot—I'm not going to try to write code to look up the image.

I don't expect you to merge this PR, but I wanted to show you it just so you were aware!

If you want the built .jar, you can get it in this release on my fork. Feel free to re-host it here if you wish!

Anyway. Hope you're doing well! Have a nice day.

comp500 commented 4 years ago

Thanks! This looks neat, although I'm rather busy at the moment so I probably won't get around to merging it for a bit.

DragonEggBedrockBreaking commented 3 years ago

This should be configurable. I prefer the current option by default, but maybe you can enable 'ask to copy', or maybe the other way around; asking to copy is default, then you can enable the option 'don't ask to copy'

comp500 commented 3 years ago

Hmm, I don't think I want to implement it this way. It would be better to read the file from disk, then you can copy any image rather than just the latest one, and I don't like the command stuff (it'd be much better to just handle the click directly rather than having it run a command).

I also want to switch to using Architectury so I can have a consistent codebase between the Forge and Fabric versions (as well as using yarn and mixins on Forge), so this PR won't be useful.