search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Fixed error causing issue #22. #23

Closed fredericpoitevin closed 2 years ago

fredericpoitevin commented 2 years ago

The error was due to a inconsistent handling of whether the model read from a PDB or CIF file was assembled into a biological assembly model or not. An "assemble" option has been added to read_gemmi_model() for both PDB and CIF inputs, and the test functions always consider the option to be False.

codecov[bot] commented 2 years ago

Codecov Report

Merging #23 (66b4d60) into master (8b47f4a) will increase coverage by 0.72%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   92.11%   92.83%   +0.72%     
==========================================
  Files           4        4              
  Lines         190      195       +5     
==========================================
+ Hits          175      181       +6     
+ Misses         15       14       -1
Impacted Files Coverage Δ
ioSPI/iotools/atomic_models.py 98.22% <100.00%> (+2.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b47f4a...66b4d60. Read the comment docs.

fredericpoitevin commented 2 years ago

I'm not sure why codecov is still running... Should we merge regardless @ninamiolane ?

fredericpoitevin commented 2 years ago

I'm closing to see if by reopening, the codecov bug disappears.