search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Simspi import #38

Closed geoffwoollard closed 2 years ago

geoffwoollard commented 2 years ago

Trying to sort out import errors in https://github.com/compSPI/ioSPI/pull/25

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (d56953e) into master (684e90c) will increase coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   94.49%   94.81%   +0.33%     
==========================================
  Files           5        5              
  Lines         308      308              
==========================================
+ Hits          291      292       +1     
+ Misses         17       16       -1
Impacted Files Coverage Δ
ioSPI/fourier.py 100.00% <0.00%> (+1.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 684e90c...d56953e. Read the comment docs.

geoffwoollard commented 2 years ago

Passing all tests branching off main.

geoffwoollard commented 2 years ago

@arjunsingh3600 I can import simSPI

ninamiolane commented 2 years ago

The test function import... does not start with test_: did you check that pytest is able to find it and run it? Sometimes, the test runners only run functions that start with test_.

ninamiolane commented 2 years ago

@geoffwoollard did this get resolve or should we close?

geoffwoollard commented 2 years ago

I will close since this PR should have been draft. It was just to point out that there was no issue importing simSPI.