search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Remove FFT code. #45

Closed fredericpoitevin closed 2 years ago

fredericpoitevin commented 2 years ago

Once/if merge, https://github.com/compSPI/compSPI/pull/28 will provide the relevant functions for performing FFT.

geoffwoollard commented 2 years ago

Code dependencies in

https://github.com/compSPI/ioSPI/blob/master/tests/test_fourier.py https://github.com/compSPI/simSPI/blob/master/simSPI/multislice.py https://github.com/compSPI/simSPI/blob/master/tests/test_multislice.py

I wrote all of this and I'm fine removing it. I can also refactor it with the FFT in compSPI. I'd like to do something with multislice eventually, but I can remove it for now and come back to it later (in pytorch).

What do you think @fredericpoitevin?

fredericpoitevin commented 2 years ago

If possible, a refactor with FFT from compSPI would be great.

geoffwoollard commented 2 years ago

ok sure, I can do that.

geoffwoollard commented 2 years ago

Once these are merged this issue can be closed.

https://github.com/compSPI/ioSPI/pull/49 https://github.com/compSPI/simSPI/pull/66