search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Remove fourier from ioSPI #49

Closed geoffwoollard closed 2 years ago

geoffwoollard commented 2 years ago

Together with https://github.com/compSPI/simSPI/pull/66 resolves https://github.com/compSPI/ioSPI/issues/45

codecov[bot] commented 2 years ago

Codecov Report

Merging #49 (ce43cf9) into master (295b6b5) will decrease coverage by 0.89%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   98.41%   97.53%   -0.88%     
==========================================
  Files           5        4       -1     
  Lines         188      121      -67     
==========================================
- Hits          185      118      -67     
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eddb5e...ce43cf9. Read the comment docs.

fredericpoitevin commented 2 years ago

The codevcov/project test fails only because there are less files to test (the numerator decreases but the denominator kept constant). I think we can merge.

ninamiolane commented 2 years ago

@geoffwoollard conflicts must be resolved, otherwise good to merge, thank you!