search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Luis master #64

Closed fredericpoitevin closed 2 years ago

fredericpoitevin commented 2 years ago

Moved #52 to the main fork to verify that tests are passing.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (1e66edc) into master (5943c63) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files           5        5           
  Lines         168      168           
=======================================
  Hits          162      162           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 403be04...1e66edc. Read the comment docs.

fredericpoitevin commented 2 years ago

@luis-sribeiro could you address the comments from #52 here, please?

Once done, please mark this pull request as ready to review and assign @ninamiolane and me as reviewers. Thanks!

ninamiolane commented 2 years ago

@luis-sribeiro any update on this?