compSPI / ioSPI

I/O and Data Visualization

MIT License

4 stars 7 forks source link

Add programmatic way to download and upload data to OSF - link to an existing project with 80s data #70

Closed ninamiolane closed 2 years ago

ninamiolane commented 2 years ago

This PR:

adds a Project class in datasets.py that allows to list, download, and upload data from an OSF project.
demonstrates its use through a notebook that download simulated ribosome data from an existing OSF project.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 2 years ago

Codecov Report

Merging #70 (cae41fd) into master (7f69dd7) will decrease coverage by 7.12%. The diff coverage is 30.77%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   97.24%   90.13%   -7.11%     
==========================================
  Files           5        5              
  Lines         217      243      +26     
==========================================
+ Hits          211      219       +8     
- Misses          6       24      +18

Impacted Files	Coverage Δ
ioSPI/datasets.py	`71.24% <30.77%> (-22.38%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4dd01a...cae41fd. Read the comment docs.

geoffwoollard commented 2 years ago

I looked at the notebooks and see how the download method of the Project class works. Are you still working on the upload method?

ninamiolane commented 2 years ago

Yes! The upload method does not give any error but does not seem to really upload anything...

Did the download method work for you? (to download from the same project as the one in my notebook?)

geoffwoollard commented 2 years ago

What about the missing lines that are not being tested? They are from the new functionality you wrote. Maybe you can turn some of the stuff in notebooks to tests and put them in https://github.com/compSPI/ioSPI/blob/master/tests/test_datasets.py

ioSPI/datasets.py               73     21    71%   31-41, 45-46, 63-65, 86-88, 181

https://github.com/compSPI/ioSPI/runs/6282964241?check_suite_focus=true#step:6:24