compSPI / ioSPI

I/O and Data Visualization

MIT License

4 stars 7 forks source link

Add Slides from hackathon presentation at PIMS #78

Open ninamiolane opened 2 years ago

ninamiolane commented 2 years ago

Checklist

Verify that your PR checks all the following items.

[x] The pull request (PR) has a clear and explanatory title.
[x] The description of this PR links to relevant GitHub issues.
[ ] Unit tests have been added in the tests folder:
- [ ] in the test_*.py files corresponding the files modified by this PR,
- [ ] for each function added by this PR.
[ ] The code of this PR is properly documented, with docstrings following ioSPI conventions.
[ ] The PR passes the DeepSource GitHub Actions workflow (refer to comment below).
[ ] The PR passes Test and Lint GitHub Actions workflows. (refer to comment below)

If some items are not checked, mark your PR as draft (Look for "Still in progress? Convert to Draft" on your PR) . Only mark the PR as "Ready for review" if all the items above are checked.

If you do not know how to address some items, reach out to a maintainer by requesting reviewers.

If some items cannot be addressed, explain the reason in the Description of your PR, and mark the PR ready for review

Description

Issue

Additional context

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 2 years ago

Codecov Report

Merging #78 (bfae498) into master (91680c8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files           5        5           
  Lines         243      243           
=======================================
  Hits          219      219           
  Misses         24       24

Impacted Files	Coverage Δ
__init__.py
ioSPI/__init__.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91680c8...bfae498. Read the comment docs.

geoffwoollard commented 2 years ago

Note that the test for Python 3.9 failed. https://github.com/compSPI/ioSPI/runs/6359063097?check_suite_focus=true

It mentioned some unicode error.

fredericpoitevin commented 2 years ago

I'll make a notebook of this on compSPI/compSPI: https://docs.google.com/presentation/d/1piiGzwW3rvu2iuv9Pe2hLTtnMtl998LcRFei6t2mOhA/edit?usp=sharing