Closed bongjinkoo closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merging #81 (4946d66) into master (91680c8) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 5 5
Lines 243 243
=======================================
Hits 219 219
Misses 24 24
Impacted Files | Coverage Δ | |
---|---|---|
ioSPI/__init__.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 91680c8...4946d66. Read the comment docs.
Checklist
Verify that your PR checks all the following items.
Description
There is an init.py file at the root of the repository.
This makes it so that the pip install through git installs the library from the root of the repository instead of the ioSPI source directory, and leads to imports errors (unless one import ioSPI.ioSPI as ioSPI first, but this is not a good thing).
The solution is to delete this file and re-install the environment. Pip should then install the right version.
Issue
79
Additional context